Improve detection of off-diagonal omega names #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 94.4% 94.35% -0.05%
==========================================
Files 40 40
Lines 3055 3065 +10
==========================================
+ Hits 2884 2892 +8
- Misses 171 173 +2
Continue to review full report at Codecov.
|
|
Closed in favor of #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I don't think it's the perfect solution, this fixes #121 for me. I think that a better parser (which is in the works) is a better long-term solution so that omega names and labels are automatically linked at parsing of the .lst file.
This replaces the PR in #146.